-
-
Notifications
You must be signed in to change notification settings - Fork 348
colorschemes/gruvbox-material: init #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorschemes/gruvbox-material: init #3608
Conversation
Signed-off-by: saygo-png <[email protected]>
Signed-off-by: saygo-png <[email protected]>
928051e
to
d68494d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
''; | ||
}; | ||
renamed.colorschemes = { | ||
# Added 2025-08-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to wait a few weeks before merging, to give users chance to update and see this deprecation warning.
Some time in September should be ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattSturgeon Could this be merged now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
https://github.com/sainnhe/gruvbox-material
My favourite Neovim gruvbox.
Removes fresh deprecation in accordance with #3495 (comment)
There is a missing
defaults
test optioncolors_override
which is by default set to an empty vimscript dictionaryI excluded it because I could not figure out how to make it empty in nix without errors. neither
__raw = "{}"
or__empty = null
worked.I tested the option with actual settings and it works fine, i just can't figure out how to make it empty for the test.